-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cardano-node: 1.19.0 -> 1.19.1 #2100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
IMPROVEMENT
Mark a PR as an improvement, for auto-generated CHANGELOG
label
Sep 2, 2020
rvl
force-pushed
the
rvl/cardano-node-1.19.1
branch
6 times, most recently
from
September 3, 2020 13:31
dff5ac4
to
fb6aab1
Compare
rvl
force-pushed
the
rvl/cardano-node-1.19.1
branch
from
September 3, 2020 13:47
fb6aab1
to
6385011
Compare
bors try |
tryBuild failedTests hit timeout and also failed.
|
bors try |
bors r+ |
👎 Rejected by too few approved reviews |
KtorZ
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May you update the matrix in the README before merging 🙏 ?
tryTimed out. |
rvl
force-pushed
the
rvl/cardano-node-1.19.1
branch
from
September 7, 2020 23:57
6385011
to
a9cec45
Compare
Thanks, bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 7, 2020
2100: cardano-node: 1.19.0 -> 1.19.1 r=rvl a=rvl ### Issue Number None ### Overview - Updates cardano-node to [1.19.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.19.1) - Back to a URL snapshot - hopefully prevents stack snapshot caching issues. - Completely disable RDRAND in cryptonite using a cabal flag. ### Comments - Needs input-output-hk/cardano-haskell#26 merged first. 2115: stack.yaml: Completely disable RDRAND support in cryptonite r=rvl a=rvl ### Issue Number Relates to ADP-428. ### Overview Ensures that RDRAND can never be the sole source of RNG entropy. To generate mnemonics it goes through cryptonite `Crypto.Random.Entropy.getEntropy`. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows). Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: IOHK <[email protected]>
Canceled. |
rvl
force-pushed
the
rvl/cardano-node-1.19.1
branch
from
September 8, 2020 00:17
3dc94b4
to
262f567
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 8, 2020
2100: cardano-node: 1.19.0 -> 1.19.1 r=rvl a=rvl ### Issue Number None ### Overview - Updates cardano-node to [1.19.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.19.1) - Back to a URL snapshot - hopefully prevents stack snapshot caching issues. - Completely disable RDRAND in cryptonite using a cabal flag. ### Comments - Needs input-output-hk/cardano-haskell#26 merged first. 2115: stack.yaml: Completely disable RDRAND support in cryptonite r=rvl a=rvl ### Issue Number Relates to ADP-428. ### Overview Ensures that RDRAND can never be the sole source of RNG entropy. To generate mnemonics it goes through cryptonite `Crypto.Random.Entropy.getEntropy`. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows). Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed (retrying...): |
Build succeeded: |
bors try- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
None
Overview
Comments