Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-node: 1.19.0 -> 1.19.1 #2100

Merged
merged 4 commits into from
Sep 8, 2020
Merged

cardano-node: 1.19.0 -> 1.19.1 #2100

merged 4 commits into from
Sep 8, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Sep 2, 2020

Issue Number

None

Overview

  • Updates cardano-node to 1.19.1
  • Back to a URL snapshot - hopefully prevents stack snapshot caching issues.
  • Completely disable RDRAND in cryptonite using a cabal flag.

Comments

@rvl rvl added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Sep 2, 2020
@rvl rvl self-assigned this Sep 2, 2020
@rvl rvl force-pushed the rvl/cardano-node-1.19.1 branch 6 times, most recently from dff5ac4 to fb6aab1 Compare September 3, 2020 13:31
@rvl rvl force-pushed the rvl/cardano-node-1.19.1 branch from fb6aab1 to 6385011 Compare September 3, 2020 13:47
@rvl
Copy link
Contributor Author

rvl commented Sep 4, 2020

bors try

iohk-bors bot added a commit that referenced this pull request Sep 4, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 4, 2020

try

Build failed

Tests hit timeout and also failed.

TRANS_CREATE_12 - Transaction with too much metadata FAILED [1]

@Anviking
Copy link
Member

Anviking commented Sep 4, 2020

bors try

@rvl
Copy link
Contributor Author

rvl commented Sep 7, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 7, 2020

👎 Rejected by too few approved reviews

iohk-bors bot added a commit that referenced this pull request Sep 7, 2020
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you update the matrix in the README before merging 🙏 ?

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 7, 2020

try

Timed out.

@rvl rvl force-pushed the rvl/cardano-node-1.19.1 branch from 6385011 to a9cec45 Compare September 7, 2020 23:57
@rvl
Copy link
Contributor Author

rvl commented Sep 7, 2020

Thanks, README.md updated now.

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 7, 2020
2100: cardano-node: 1.19.0 -> 1.19.1 r=rvl a=rvl

### Issue Number

None

### Overview

- Updates cardano-node to [1.19.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.19.1)
- Back to a URL snapshot - hopefully prevents stack snapshot caching issues.
- Completely disable RDRAND in cryptonite using a cabal flag.

### Comments

- Needs input-output-hk/cardano-haskell#26 merged first.


2115: stack.yaml: Completely disable RDRAND support in cryptonite r=rvl a=rvl

### Issue Number

Relates to ADP-428.

### Overview

Ensures that RDRAND can never be the sole source of RNG entropy.

To generate mnemonics it goes through cryptonite `Crypto.Random.Entropy.getEntropy`. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows).


Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: IOHK <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 8, 2020

Canceled.

@rvl rvl force-pushed the rvl/cardano-node-1.19.1 branch from 3dc94b4 to 262f567 Compare September 8, 2020 00:17
@rvl
Copy link
Contributor Author

rvl commented Sep 8, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 8, 2020
2100: cardano-node: 1.19.0 -> 1.19.1 r=rvl a=rvl

### Issue Number

None

### Overview

- Updates cardano-node to [1.19.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.19.1)
- Back to a URL snapshot - hopefully prevents stack snapshot caching issues.
- Completely disable RDRAND in cryptonite using a cabal flag.

### Comments

- Needs input-output-hk/cardano-haskell#26 merged first.


2115: stack.yaml: Completely disable RDRAND support in cryptonite r=rvl a=rvl

### Issue Number

Relates to ADP-428.

### Overview

Ensures that RDRAND can never be the sole source of RNG entropy.

To generate mnemonics it goes through cryptonite `Crypto.Random.Entropy.getEntropy`. Disabling the RDRAND backend will leave just the WinCryptoAPI (windows) and DevRandom, DevURandom backends (not windows).


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 8, 2020

Build failed (retrying...):

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 8, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit e2b72cc into master Sep 8, 2020
@iohk-bors iohk-bors bot deleted the rvl/cardano-node-1.19.1 branch September 8, 2020 02:38
@rvl
Copy link
Contributor Author

rvl commented Sep 8, 2020

bors try-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants